Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use position "hidden" flag as source for identifying hidden position records #820

Open
kenkunz opened this issue Sep 18, 2024 · 0 comments
Assignees
Labels
priority: P2 Default priority. An issue might not yet be fixed in the next release. size: XS A trivial task that can be completed in less than an hour type: tech debt Technical debt

Comments

@kenkunz
Copy link
Contributor

kenkunz commented Sep 18, 2024

Goal

As a strategy admin, I want the source of data for identifying position records to be hidden in the UI to be the position record from the trade-executor state API payload.

Background

Acceptance criteria

Given: a position that has been flagged as hidden on the backend (see tradingstrategy-ai/trade-executor#1041):

  1. For non-admin users
    1. the position is hidden on the strategy positions table
    2. the route for the position details returns a 404 Not found
  2. For admin users
    1. the position is included on the strategy positions table with a hidden badge shown and reduced opacity on the table row to indicate that this position would be hidden for non-admin users
    2. the route for the position details displays the position, with a hidden badge
  3. The frontend strategy config no longer includes hiddenPositions array (this was a stop-gap solution until we had the proper backend solution)
@kenkunz kenkunz added priority: P2 Default priority. An issue might not yet be fixed in the next release. size: XS A trivial task that can be completed in less than an hour type: tech debt Technical debt labels Sep 18, 2024
@kenkunz kenkunz self-assigned this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: P2 Default priority. An issue might not yet be fixed in the next release. size: XS A trivial task that can be completed in less than an hour type: tech debt Technical debt
Projects
None yet
Development

No branches or pull requests

1 participant