API Update API to reflect changes to CLI interaction #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
Sep 6, 2024
There was a problem hiding this comment.
Removed this because the translatable module hasn't been a thing for a really long time - it's time to remove this task.
GuySartorelli
force-pushed
the
pulls/8/symfony-sake
branch
from
d551a99
to
812088d
Compare
This was referenced Sep 10, 2024
GuySartorelli
force-pushed
the
pulls/8/symfony-sake
branch
2 times, most recently
from
77bfe7e
to
b252028
Compare
GuySartorelli
force-pushed
the
pulls/8/symfony-sake
branch
from
b252028
to
d614980
Compare
tractorcow
approved these changes
Sep 18, 2024
|
Approved, but pending build to pass. |
|
This PR (and it'll be the case with most of the CMS 6 PRs) relies on code in other PRs. They'll all need to be merged together. |
GuySartorelli
force-pushed
the
pulls/8/symfony-sake
branch
2 times, most recently
from
84ddaff
to
0d4de77
Compare
GuySartorelli
force-pushed
the
pulls/8/symfony-sake
branch
from
0d4de77
to
fd38fcd
Compare
emteknetnz
approved these changes
Sep 26, 2024
|
CI failures don't look related to the changes in this PR - running a regular CI run to see if it fails the same way. https://github.com/tractorcow-farm/silverstripe-fluent/actions/runs/11060232590 |
|
Main CI isn't even getting that far. |
emteknetnz
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflects changes in silverstripe/silverstripe-framework#11353
Issue