Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an xtask task to update CI binaries #8

Open
Luni-4 opened this issue Feb 3, 2024 · 4 comments
Open

Add an xtask task to update CI binaries #8

Luni-4 opened this issue Feb 3, 2024 · 4 comments

Comments

@Luni-4
Copy link

Luni-4 commented Feb 3, 2024

Feature description

Add an xtask task to automatically check for whether there are new versions of Continuous Integration binaries. It might be structured in the following way:

  1. Use serde_yaml to parse the yml files in search of environment variables which could be defined as:
    • _BINARY_URL: "url"
    • _BINARY_NAME_VERSION: "x.x.x"
  2. Using url to evaluate if there is a BINARY_NAME with a release version greater than x.x.x through the reqwest crate
  3. If there is a new version, the task updates the _BINARY_NAME_VERSION value, thus changing files

Feature motivation

This task makes less tedious the updating of Continuous Integration binaries. This check can also be integrated into a Continuous Integration action which automatically opens a PR with the updates.

@Luni-4 Luni-4 self-assigned this Feb 5, 2024
@Luni-4 Luni-4 removed their assignment Nov 4, 2024
@Luni-4
Copy link
Author

Luni-4 commented Nov 4, 2024

I've lost the track about this issue @syl20bnr, but I've seen that now we are using external tracel actions, so I suppose this one is no more necessary, or it should be moved out to a more appropriate repository. Let me know if I've correctly figured out the situation

@syl20bnr
Copy link
Member

syl20bnr commented Nov 6, 2024

This kind of command can still be useful.

Here is the current situation:

Maybe the github-actions repo could depend on tracel-xtask and we create a custom command there to at least check for the versions that are in composite actions and shared workflows. Then depending on how the command is implemented we could move it up to tracel-xtask as a base command.

@Luni-4
Copy link
Author

Luni-4 commented Nov 7, 2024

I can think of two scenarios:

  1. If all github-actions depends on tracel-xtask we can implement a mechanism for updating a tool directly in tracel-xtask. Thus, we do not have to add any command because every CI step calls tracel-xtask.
  2. If we have a github-actions, which installs a tool and use that independently, without passing through tracel-xtask we need to come up with a command for changing the content of CI scripts.

In both case, it seems a tracel-xtask issue to me.

@syl20bnr syl20bnr transferred this issue from tracel-ai/burn Nov 8, 2024
@syl20bnr
Copy link
Member

syl20bnr commented Nov 8, 2024

Yes you are right, transferred to tracel-ai/xtask repo.
I believe we should do 1 and have all the actions or workflows depends on tracel-xtask but we need a command that is flexible enough to work everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants