Remainder method not working correctly

[akshitgaur2005]

Describe the bug
Remainder sometimes giving wrong output

To Reproduce

let lhs: Tensor<MyBackend, 1> =
        Tensor::from_floats([-1.4843, 1.1350, -2.1563, 1.0862, 0.5034, 3.6587], &device);
    let rhs: Tensor<MyBackend, 1> =
        Tensor::from_floats([-1.4843, 1.1350, -2.1563, 1.0862, 0.5034, 3.6587], &device);

    let output = lhs.remainder(rhs);
    // Output: [-1.4843, 0.0, 0.0, 0.0, 0.5034, 0.0]

Expected behavior

let expected = TensorData::from([0., 0., 0., 0., 0., 0.]);

[laggui]

So this unit test is failing on your machine?

burn/crates/burn-tensor/src/tests/ops/remainder.rs

Lines 90 to 106 in 3ad5343

	#[test]
	fn should_have_no_remainder() {
	let device = Default::default();
	let lhs = Tensor::<TestBackend, 1>::from_data(
	TensorData::from([-1.4843, 1.1350, -2.1563, 1.0862, 0.5034, 3.6587]),
	&device,
	);
	let rhs = Tensor::<TestBackend, 1>::from_data(
	TensorData::from([1.4843, 1.1350, 2.1563, 1.0862, 0.5034, 3.6587]),
	&device,
	);
	let output = lhs.remainder(rhs);
	let expected = TensorData::from([-0., 0., -0., 0., 0., 0.]);
	output.into_data().assert_approx_eq(&expected, 3);
	}

For what backend? If it's a GPU backend, what GPU do you have?

[akshitgaur2005]

Yes, atleast in the example that I used, Wgpu. GTX 1650

[maxtremblay]

Same here on Wgpu with a Nvidia GeForce RTX 4060. I don't know what is special with the value 0.5034.