Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy and release scripts #79

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Deploy and release scripts #79

wants to merge 11 commits into from

Conversation

dukris
Copy link
Collaborator

@dukris dukris commented Mar 7, 2024

@h1alexbel take a look, please

Closes #6
Closes #81


PR-Codex overview

The focus of this PR is to update deployment and release configurations for the project.

Detailed summary

  • Updated Nginx configuration for port switching
  • Added Docker Compose configuration for Keycloak and project services
  • Enhanced deployment and release scripts for seamless operations

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@dukris dukris requested a review from h1alexbel March 7, 2024 15:14
Copy link
Collaborator

@h1alexbel h1alexbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hizmailovich take a look, please

.rultor.yml Outdated Show resolved Hide resolved
.rultor.yml Show resolved Hide resolved
.rultor.yml Outdated Show resolved Hide resolved
.rultor.yml Outdated Show resolved Hide resolved
@dukris dukris requested a review from h1alexbel March 11, 2024 13:39
Copy link
Collaborator

@h1alexbel h1alexbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hizmailovich overall looks good, but I don't really got where we are using swap.sh and up.sh

@dukris
Copy link
Collaborator Author

dukris commented Mar 12, 2024

@h1alexbel
First of all we should use up.sh. This script starts a new version of the app on "green" port, so we can test this version using prefix /api-test/..., which was configured in default-*.conf file.
Then after testing we can replace our stable "blue" version with the "green" one using swap.sh. This script will switch prefixes and stop the "blue" container.

@h1alexbel
Copy link
Collaborator

@hizmailovich I got the idea why do we need those scripts. But my original claim was "where" those scripts are used, I don't see them in .rultor.yml to be executed on deployment

@dukris
Copy link
Collaborator Author

dukris commented Mar 12, 2024

@h1alexbel release section, here

@h1alexbel h1alexbel closed this Mar 12, 2024
@h1alexbel h1alexbel reopened this Mar 12, 2024
@h1alexbel
Copy link
Collaborator

h1alexbel commented Mar 12, 2024

@hizmailovich here you described how to release a new version to the server, should we pass only one script to execute blue-green deployment?

Also, let's move "How to Contribute" section to the bottom of the README

@h1alexbel
Copy link
Collaborator

@hizmailovich let's make sure release happens in just one command (tests and swap should be executed internally). Since rultor release... makes a GitHub release with immutable tag we can't release the same version twice. Besides that it would be much more convenient to do that seamless deployment in just one command. WDYT?

@dukris dukris requested a review from h1alexbel March 14, 2024 09:32
Copy link
Collaborator

@h1alexbel h1alexbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets see

@h1alexbel
Copy link
Collaborator

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Mar 21, 2024

@rultor merge

@h1alexbel Thanks for your request; @hizmailovich please confirm this.

@dukris
Copy link
Collaborator Author

dukris commented Apr 26, 2024

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Apr 26, 2024

@rultor merge

@hizmailovich Can't merge this pull requests, because the file .rultor.yml was modified. This is a security threat. Make a separate pull request with the modification of this particular file and ask project architect to merge it manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants