Skip to content

Commit 87b7407

Browse files
authored
Merge pull request #1273 from dough29/feat/waze-navigation
Add navigation app link in status card
2 parents 2154ff1 + 9b0f4c9 commit 87b7407

File tree

3 files changed

+14
-0
lines changed

3 files changed

+14
-0
lines changed

src/common/attributes/useCommonUserAttributes.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,4 +137,12 @@ export default (t) => useMemo(() => ({
137137
name: t('sharedIconScale'),
138138
type: 'number',
139139
},
140+
navigationAppLink: {
141+
name: t('attributeNavigationAppLink'),
142+
type: 'string',
143+
},
144+
navigationAppTitle: {
145+
name: t('attributeNavigationAppTitle'),
146+
type: 'string',
147+
},
140148
}), [t]);

src/common/components/StatusCard.jsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,9 @@ const StatusCard = ({ deviceId, position, onClose, disableActions, desktopPaddin
126126
const positionAttributes = usePositionAttributes(t);
127127
const positionItems = useAttributePreference('positionItems', 'fixTime,address,speed,totalDistance');
128128

129+
const navigationAppLink = useAttributePreference('navigationAppLink');
130+
const navigationAppTitle = useAttributePreference('navigationAppTitle');
131+
129132
const [anchorEl, setAnchorEl] = useState(null);
130133

131134
const [removing, setRemoving] = useState(false);
@@ -269,6 +272,7 @@ const StatusCard = ({ deviceId, position, onClose, disableActions, desktopPaddin
269272
<MenuItem component="a" target="_blank" href={`https://www.google.com/maps/search/?api=1&query=${position.latitude}%2C${position.longitude}`}>{t('linkGoogleMaps')}</MenuItem>
270273
<MenuItem component="a" target="_blank" href={`http://maps.apple.com/?ll=${position.latitude},${position.longitude}`}>{t('linkAppleMaps')}</MenuItem>
271274
<MenuItem component="a" target="_blank" href={`https://www.google.com/maps/@?api=1&map_action=pano&viewpoint=${position.latitude}%2C${position.longitude}&heading=${position.course}`}>{t('linkStreetView')}</MenuItem>
275+
{navigationAppTitle && <MenuItem component="a" target="_blank" href={navigationAppLink.replace('{latitude}', position.latitude).replace('{longitude}', position.longitude)}>{navigationAppTitle}</MenuItem>}
272276
{!shareDisabled && !user.temporary && <MenuItem onClick={() => navigate(`/settings/device/${deviceId}/share`)}>{t('deviceShare')}</MenuItem>}
273277
</Menu>
274278
)}

src/resources/l10n/en.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,8 @@
150150
"attributeMailSmtpAuth": "Mail: SMTP Auth Enable",
151151
"attributeMailSmtpUsername": "Mail: SMTP Username",
152152
"attributeMailSmtpPassword": "Mail: SMTP Password",
153+
"attributeNavigationAppLink": "Navigation app link",
154+
"attributeNavigationAppTitle": "Navigation app title",
153155
"attributeUiDisableSavedCommands": "UI: Disable Saved Commands",
154156
"attributeUiDisableAttributes": "UI: Disable Attributes",
155157
"attributeUiDisableGroups": "UI: Disable Groups",

0 commit comments

Comments
 (0)