Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions printing if you have never discovered #131

Open
Sheaffy opened this issue Jan 22, 2024 · 0 comments
Open

Permissions printing if you have never discovered #131

Sheaffy opened this issue Jan 22, 2024 · 0 comments

Comments

@Sheaffy
Copy link

Sheaffy commented Jan 22, 2024

I stumbled across this when implementing this lib. (Nice work so far btw!)

I noticed that if you happen to already know the bluetooth address and attempt to connect to it without ever using discovery, it does not prompt for permissions through the lib.

Correct me if I'm wrong, but I'm thinking it may be beneficial to document that you could use the "requestAndroidPermissions" function in the permissions util in "react-native-esc-pos-printer/src/core/utils/permissions" to achieve this before you attempt to connect. (Should you not use discover)

Happy to make a PR containing documentation if you would like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant