Commit 91dc096
committed
π fix(subprocess): add timeout to interpreter probing
On Windows CI, the subprocess spawned to probe a candidate Python
interpreter can hang indefinitely β triggered by Windows Store stubs,
antivirus holds, or pipe I/O race conditions. This caused ~18 flaky
timeout failures across 9 different tests in tox over the last 30 days,
almost exclusively on windows-2025 runners.
The root cause is process.communicate() being called with no timeout
in _run_subprocess. Adding a 5s timeout and killing the process on
expiry allows discovery to skip unresponsive interpreters and continue.1 parent 1ee6488 commit 91dc096
File tree
2 files changed
+17
-2
lines changed- src/python_discovery
- tests
2 files changed
+17
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
206 | 206 | | |
207 | 207 | | |
208 | 208 | | |
209 | | - | |
| 209 | + | |
210 | 210 | | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
211 | 214 | | |
212 | 215 | | |
213 | 216 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| |||
110 | 111 | | |
111 | 112 | | |
112 | 113 | | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
113 | 125 | | |
114 | 126 | | |
115 | 127 | | |
| |||
0 commit comments