Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgnp: finish local connection establishment handshakes #12

Open
hawkw opened this issue Nov 2, 2023 · 0 comments
Open

mgnp: finish local connection establishment handshakes #12

hawkw opened this issue Nov 2, 2023 · 0 comments
Labels
enhancement New feature or request
Milestone
MGNP v0.1

Comments

@hawkw
Copy link
Contributor

hawkw commented Nov 2, 2023

from #2:

Currently, when a local connect is initiated, the client just
immediately gets a BiDi, regardless of whether the connect succeeds or
fails. We need to add a oneshot channel type thing so that the client
can wait for the connection to be handshaked and receive an error if
the handshake failed, but I haven't done that yet.

Depends on #11.
@hawkw hawkw added the enhancement New feature or request label Nov 2, 2023
@hawkw hawkw mentioned this issue Nov 2, 2023
Open
5 tasks
@hawkw hawkw added this to the MGNP v0.1 milestone Nov 2, 2023
@hawkw hawkw mentioned this issue Nov 10, 2023
Merged
hawkw added a commit that referenced this issue Nov 10, 2023
@hawkw
feat(mgnp): add handshaking, redo outbound frame API (#21)
87dc51d 
This branch implements a bunch more of the MGNP protocol, including
`Hello` messages for connection establishment (see #12). In addition,
I've redone the frame types, including a much more usable
`OutboundFrame` API for the `Wire` implementation, which should be much
easier to serialize (see #13).

Furthermore, I've added a bunch more tests (see #14).

Closes #13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
MGNP v0.1
Development

No branches or pull requests
1 participant
@hawkw