Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asyncmy integration broken #1814

Open
henadzit opened this issue Dec 17, 2024 · 1 comment
Open

asyncmy integration broken #1814

henadzit opened this issue Dec 17, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@henadzit
Copy link
Contributor

Describe the bug
Looks like asyncmy integration is broken. The errors module of asyncmy is not available but there might be other issues. It's quite unfortunate because we suggest asyncmy as a default option for MySQL in the docs.

Screenshot 2024-12-17 at 11 54 20

To Reproduce
Replace aiomysql in the deps command in Makefile with asyncmy and run TORTOISE_MYSQL_PASS=123456 make test_mysql.

Expected behavior

  • asyncmy integration should be working
  • We should have a test suite running against asyncmy, at the moment we only run tests with aiomysql
@henadzit henadzit added the bug Something isn't working label Dec 17, 2024
@waketzheng
Copy link
Contributor

Agree. And we should add asyncmy integration test to ci:

       - name: Run ci
         run: make ci
+      - name: Test asyncmy integration
+        run: |
+          poetry run pip install asyncmy
+          make test_mysql
+          make test_mysql_myisam  # I don't known whether this is required
       - name: Test FastAPI Example
         run: |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants