Skip to content

Fix code scanning alert no. 49: Uncontrolled data used in path expression #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix code scanning alert no. 49: Uncontrolled data used in path expression #685

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/pages/api/v1/course/update.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { withMethods } from "@/lib/api-middlewares/with-method";
import { withUserAuthorized } from "@/lib/api-middlewares/with-authorized";
import { createSlug, getFileExtension } from "@/lib/utils";
import fs from "fs";
import path from "path";
import { APIResponse } from "@/types/apis";
import { readFieldWithSingleFile } from "@/lib/upload/utils";
import { ContentManagementService } from "@/services/cms/ContentManagementService";
Expand Down Expand Up @@ -59,8 +60,12 @@ const handler = async (req: NextApiRequest, res: NextApiResponse) => {
}

const extension = getFileExtension(files.file[0].originalFilename);
const sourcePath = files.file[0].filepath;
const fileBuffer = await fs.promises.readFile(`${sourcePath}`);
const sourcePath = path.resolve(files.file[0].filepath);
const safeDir = path.resolve("/var/www/uploads"); // Replace with your safe directory
if (!sourcePath.startsWith(safeDir)) {
throw new Error("Invalid file path");
}
const fileBuffer = await fs.promises.readFile(sourcePath);
//now upload the image
const newThumbnailResponse = await cms.uploadVideoThumbnail(
cmsConfig,
Expand Down
Loading