Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notino_cz - špatné ceny u produktů s kódem #2499

Closed
MartinaGelnerova opened this issue Oct 4, 2024 · 7 comments · Fixed by #2573
Closed

Notino_cz - špatné ceny u produktů s kódem #2499

MartinaGelnerova opened this issue Oct 4, 2024 · 7 comments · Fixed by #2573

Comments

@MartinaGelnerova
Copy link
Collaborator

př: https://www.notino.cz/makeup-revolution/xmass-2024-advent-calendar-adventni-kalendar/
image

správné hodnoty: currentPrice 1386, originalPrice 1540
actor vrací: currentPrice 1540 (tj cenu bez kódu), originalPrice null (ignoruje "Minimální cena")
extenze vrací: currentPrice 1540 (tj cenu bez kódu), originalPrice 1386 (tj cenu s kódem => správně "Minimální cena")

@MartinaGelnerova
Copy link
Collaborator Author

@valekjo is taking look into this

@MartinaGelnerova
Copy link
Collaborator Author

@rarous pls merge

@rarous
Copy link
Collaborator

rarous commented Oct 25, 2024

@MartinaGelnerova please build&check :)

@MartinaGelnerova
Copy link
Collaborator Author

works just fine, closing the issue

@MartinaGelnerova
Copy link
Collaborator Author

@valekjo please correct originalPrice - in case "Minimální cena" is present (not always is), preferable use this as originalPrice
example: https://www.notino.cz/artdeco/color-booster-balzam-pro-podporu-prirozene-barvy-rtu/
image

Extension still waiting to be corrected... @vaclav-slavik

@valekjo
Copy link
Contributor

valekjo commented Nov 6, 2024

@MartinaGelnerova here: #2610

If the recent price is present in data, we'll use it for originalPrice for the products with voucher discount.

@rarous
Copy link
Collaborator

rarous commented Dec 3, 2024

Extension is in #2609

@rarous rarous closed this as completed Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants