onChange and value

[Nondv]

Hello!
I assume that if :value attribute is constant it will be always the same.
But I can easily change value of this component:

(rum/defc  my-input []
  [:input {:on-change js/console.log :value "whatever"}])

But! if I completely remove :on-change it will be all right.
Is it expected behavior? What should I do?

[Nondv]

Well, it appears that Sablono wraps elements with value (such as select and input):
it creates component around element and creates element state.

https://github.com/tonsky/sablono/blob/master/src/sablono/interpreter.cljc#L27

In short, it does not produce this:

<input value="whatever" onChange={log} />

but this:

<wrapper value="whatever" onChange={log}>
  <input value={inputState.state_value} onChange={innerOnChange} />
</wrapper>

where innerOnChange is like

function(v) {
  if(!wrapper.props.onChange) return;

  input.setState({ state_value: v })
  wrapper.props.onChange(v);
}

[Nondv]

r0man/sablono#148

[tonsky]

Yeah. Inputs are a huge mess in Rum/Sablono/React integration. I hope to fix or at least clean it up one day

[rauhs]

I think the simplest would be to throw out the wrapped components and synchronously call inst.forceUpdate() on a change to :rum/local. Then we'd just have the same behaviour as the React folks.

[tonsky]

that is true. Have to ditch sablono first though

[roman01la]

@Nondv Please try to repro this in 0.12.0-SNAPSHOT and report any issues to #205

[roman01la]

fixed in 0.12.0