gzippo is not working with newest connect/express

[Almad]

staticSend has been extracted to separate library

[Almad]

(sorry for the first bad fix)

[uipoet]

+1. Updated to express 3.0.0beta6 and no worky.

[dhruv-bhatia]

npm install [email protected] on the culprit project seems to fix this for me (I'm on the latest [email protected] with Gzippo working as expected).

[ryanseys]

Line 17 to 21

try {
    staticSend = require('connect').static.send; //returns undefined, doesn't throw an error
} catch (e) {
    staticSend = require('express').static.send;
}

require('connect').static.send; //returns undefined, so test for undefined
//or reorder so that staticSend = require('express').static.send; is tried before require('connect').static.send;

[serby]

+1 When will this be fixed?

[aozora]

+1 needed!

[reid-rigo]

my proposed solution is the following: reid-rigo@555be0c

using connect as a dependency instead of the connect/express shenanigans, i rework the pass() function to simply pass non-eligible requests to the connect 2.5.x static middleware

[TravelingTechGuy]

Using Express3.0.0rc4, getting this error. I think it's the same others are experiencing, if not, I'll move to another issue:

/Users/Projects/tq/server/node_modules/gzippo/lib/staticGzip.js:108
staticSend(req, res, next, o);
^
TypeError: undefined is not a function
at pass (/Users/Projects/tq/server/node_modules/gzippo/lib/staticGzip.js:108:4)
at module.exports (/Users/Projects/tq/server/node_modules/gzippo/lib/staticGzip.js:185:12)
at Object.oncomplete (fs.js:297:15)

[tomgco]

Hello,

First I would like to apologise my own lack on involvement in the project recently, I shouldn't of let the state of the module have no major development and I should of responded to these issues much sooner. The good news is that I am going to make a big push on getting as many fixes pushed out asap and possibly finish the major refactor I have been working on.

Onto the issue:

I have just install the latest version of express on my machine: [email protected] which is utilising [email protected] and I am seeing the same issue, I am currently working on a fix at this moment and will update this issue as soon as I have made the merge and the deployment.

Again I would like to apologise for my lack of response.

~tomgco

[glynnbird]

I too have the same issue.

[tomgco]

0.2 has been released, hopefully this fixes the incompatibility. Let me know if any problems occur. I will keep this open just in case.