From 09eba8675d1de23a557ba869c078937e7dc1f601 Mon Sep 17 00:00:00 2001
From: James Stronz <james@network-perception.com>
Date: Sat, 25 May 2019 02:09:54 -0500
Subject: [PATCH] Style, comment, and release cleanup

---
 rpyc/core/netref.py  | 11 +++++++----
 rpyc/lib/__init__.py | 12 +-----------
 rpyc/version.py      |  2 +-
 3 files changed, 9 insertions(+), 16 deletions(-)

diff --git a/rpyc/core/netref.py b/rpyc/core/netref.py
index 26d596f3..4dc91160 100644
--- a/rpyc/core/netref.py
+++ b/rpyc/core/netref.py
@@ -59,6 +59,7 @@
     ])
 _normalized_builtin_types = {}
 
+
 def syncreq(proxy, handler, *args):
     """Performs a synchronous request on the given proxy object.
     Not intended to be invoked directly.
@@ -117,8 +118,11 @@ class BaseNetref(with_metaclass(NetrefMetaclass, object)):
     Do not use this class directly; use :func:`class_factory` instead.
 
     :param conn: the :class:`rpyc.core.protocol.Connection` instance
-    :param id_pack: id tuple for an object such that (remote-obj-type-id, remote-obj-id)
-        (cont.) if remote-obj-type-id == remote-obj-id then object is a class. Otherwise, object is not a class
+    :param id_pack: id tuple for an object ~ (name_pack, remote-class-id, remote-instance-id)
+        (cont.) name_pack := __module__.__name__ (hits or misses on builtin cache and sys.module)
+                remote-class-id := id of object class (hits or misses on netref classes cache and instance checks)
+                remote-instance-id := id object instance (hits or misses on proxy cache)
+        id_pack is usually created by rpyc.lib.get_id_pack
     """
     __slots__ = ["____conn__", "____id_pack__", "__weakref__", "____refcount__"]
 
@@ -217,7 +221,7 @@ def __reduce_ex__(self, proto):
     def __instancecheck__(self, other):
         # support for checking cached instances across connections
         if isinstance(other, BaseNetref):
-            if self.____id_pack__[1] ==  self.____id_pack__[1]:
+            if self.____id_pack__[1] == self.____id_pack__[1]:
                 return True
             else:
                 return syncreq(self, consts.HANDLE_INSTANCECHECK, other.____id_pack__)
@@ -298,7 +302,6 @@ def class_factory(id_pack, methods):
     return type(name_pack, (BaseNetref,), ns)
 
 
-#_normalized_builtin_types = {get_id_pack(_builtin): _builtin for _builtin in _builtin_types}
 for _builtin in _builtin_types:
     _id_pack = get_id_pack(_builtin)
     _name_pack = _id_pack[0]
diff --git a/rpyc/lib/__init__.py b/rpyc/lib/__init__.py
index b340308c..50a30d9e 100644
--- a/rpyc/lib/__init__.py
+++ b/rpyc/lib/__init__.py
@@ -151,16 +151,7 @@ def exp_backoff(collision):
 
 
 def get_id_pack(obj):
-    """introspects the given (local) object, returns id_pack as expected by BaseNetref
-
-    aliases,
-    cross-connection,
-    builtins,
-    sys-modules,
-    type or instance
-
-    # version compatibility without reload, b/c of ____oid__
-    """
+    """introspects the given (local) object, returns id_pack as expected by BaseNetref"""
     if not inspect.isclass(obj):
         name_pack = '{}.{}'.format(obj.__class__.__module__, obj.__class__.__name__)
         return (name_pack, id(type(obj)), id(obj))
@@ -169,7 +160,6 @@ def get_id_pack(obj):
         return (name_pack, id(obj), 0)
 
 
-
 def get_methods(obj_attrs, obj):
     """introspects the given (local) object, returning a list of all of its
     methods (going up the MRO).
diff --git a/rpyc/version.py b/rpyc/version.py
index aa4dd95e..c0200dc9 100644
--- a/rpyc/version.py
+++ b/rpyc/version.py
@@ -1,3 +1,3 @@
-version = (4, 0, 3)
+version = (4, 1, 0)
 version_string = ".".join(map(str, version))
 release_date = "2019.05.25"