Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative blackbody radius :) #115

Open
gabrielastro opened this issue Oct 1, 2024 · 0 comments
Open

Negative blackbody radius :) #115

gabrielastro opened this issue Oct 1, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@gabrielastro
Copy link

gabrielastro commented Oct 1, 2024

Hello again! I am doing:

Pargrenzen = {}
Parnormprior = {}

Pargrenzen['disk_teff']   = (10., 1000.)
# needs to be present to "activate" the variable
#   even though we will set normal priors afterwards:
Pargrenzen['disk_radius'] = (0., 700.)

# eine gaußsche Kurve für 200 ± 200 RJup
Parnormprior['disk_radius'] = (200, 200.)

fit = FitModel(…, bounds=Pargrenzen, normal_prior=Parnormprior)

and get a best-fitting disc radius of… -6 RJup :).
Bildschirmfoto von 2024-10-01 20-58-32
Actually, the mean is zero because there is a peak at +6 RJ too. However, e.g. the mass posterior is not symmetric: high-mass solutions are possible with a negative blackbody radius but not with +6 RJup.

Two things here: It would be good to restrict R to be positive, of course, but I thought that if both bounds and normal_priors are set, the bounds would truncate the normal_priors. I looked again but maybe I missed it in the documentation of FitModel. Is it the same behaviour for all parameters: the final prior not being the multiplication of the top-hat from bounds and the Gaußian from normal_prior?

@tomasstolker tomasstolker added the enhancement New feature or request label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants