Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the reported luminosity be the luminosity only of the atmosphere #113

Open
gabrielastro opened this issue Sep 25, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@gabrielastro
Copy link

Currently, the - luminosity = reported under Calculate multi-photometry and plotted in the corner plot (as log(L/LSun)) is the (reddened) photospheric luminosity PLUS the integrated luminosity of the additional blackbody.

I would like to suggest that the much more useful quantity is the atmospheric luminosity only; the (additional) blackbody is usually not an earnest fit that is reliable enough to be integrated, especially if no far-infrared data or so are available.

species already conveniently shows L_disc/L_atm in the corner plot to let the user check the importance of the blackbody, which is very nice. However, the main output of interest is the luminosity of the atmosphere, I would say, especially in the light of comparing the results from different atmospheric models.

The less obvious question is whether to report the de-reddened luminosity and/or the "empirical" one that comes from fitting a reddened atmospheric model. Both are useful: L_bol,empirical for comparing between observations and/or models, and L_bol,deredded for use with evolutionary models (assuming that the extinction is exterior enough to the planet for it not to affect its cooling, which is ok to first order or much better, e.g. for extinction really from the ISM).

Thanks to your help, I do have a script to compute the intrinsic and the de-reddened luminosities 🤓 but maybe it would be useful in general 🙂 and if the calculation were done automatically!

@tomasstolker tomasstolker added the enhancement New feature or request label Sep 25, 2024
@gabrielastro
Copy link
Author

(Thanks for adding the label.) This would affect also in a positive way the luminosity that can easily be added to the legend of plot_spectrum through leg_param for an easy overview. I guess luminosity should be renamed to be explicit.

And on a related note, it would be nice to be able to just add e.g. mass or, especially, luminosity to the legend entry, without however having to set all other parameters, especially since they are different for most model families. The current default settings are great and it would be nice to just have the option to add luminosity/mass/Bayesian evidence/… Thanks if this is not too much trouble to implement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants