Incorrect ordering of multiple exposures due to behavior of glob

[lorenzo-pino1]

In my version of python and with my filesystem, the glob function returns file names in an incorrect ordering (see example in the end, which is the 'fits_item' generator converted to a list). Since naming output is based on the fits_idx index generated by enumerate, the spectra result reshuffled after the analysis.

I have noticed this behavior only in fit_gaussian, while in other functions the order is correctly enforced.

Proposed fix (inelegant, but is compatible with the rest of the code):

        fits_files = list(Path(input_folder).glob(
            f"cr2res_combined{nod_ab}_*_extr2d.fits"
        ))

        fits_files.sort(key=lambda x: int(x.stem.split('_')[2]))

/Users/pino/Programs_work/HD169142_appo/analysis_raw_data/product/custom_extract_2d/cr2res_combinedB_002_extr2d.fits
/Users/pino/Programs_work/HD169142_appo/analysis_raw_data/product/custom_extract_2d/cr2res_combinedB_007_extr2d.fits
/Users/pino/Programs_work/HD169142_appo/analysis_raw_data/product/custom_extract_2d/cr2res_combinedB_004_extr2d.fits
/Users/pino/Programs_work/HD169142_appo/analysis_raw_data/product/custom_extract_2d/cr2res_combinedB_008_extr2d.fits
/Users/pino/Programs_work/HD169142_appo/analysis_raw_data/product/custom_extract_2d/cr2res_combinedB_001_extr2d.fits
/Users/pino/Programs_work/HD169142_appo/analysis_raw_data/product/custom_extract_2d/cr2res_combinedB_006_extr2d.fits
/Users/pino/Programs_work/HD169142_appo/analysis_raw_data/product/custom_extract_2d/cr2res_combinedB_003_extr2d.fits
/Users/pino/Programs_work/HD169142_appo/analysis_raw_data/product/custom_extract_2d/cr2res_combinedB_000_extr2d.fits
/Users/pino/Programs_work/HD169142_appo/analysis_raw_data/product/custom_extract_2d/cr2res_combinedB_005_extr2d.fits

[tomasstolker]

Thanks for opening this issue! I have pushed an update which hopefully fixes this. Applying sorted() should probably be sufficient. Just in case, I have also added sorted() to other glob() cases where the sorting was missing. Let me know if that works as expected!