Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master flat no longer correctly included in SOF #16

Open
tomasstolker opened this issue Feb 21, 2024 · 0 comments
Open

Master flat no longer correctly included in SOF #16

tomasstolker opened this issue Feb 21, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@tomasstolker
Copy link
Owner

The flat correction was not applied by methods such as util_calib and obs_nodding because the UTIL_MASTER_FLAT key is no longer supported in the SOF file by the recent EsoRex recipes. Instead, only the CAL_FLAT_MASTER key can be used.

This issue has been fixed in commit 00cb0f3.

The commit also implements the create_sof parameter in all methods that use a SOF file. When setting to False, a previously created SOF is not overwritten so it can be manually adjusted.

@tomasstolker tomasstolker added the bug Something isn't working label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant