Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convention regarding inclination sign #1

Open
VChristiaens opened this issue Apr 9, 2021 · 1 comment
Open

Convention regarding inclination sign #1

VChristiaens opened this issue Apr 9, 2021 · 1 comment
Labels
question Further information is requested

Comments

@VChristiaens
Copy link

Hi @tomasstolker, first thanks for making this very nice and well-documented package public! I am sure it will be very useful to the community!
I was wondering what was the convention re: +/- sign in front of the inclination, in terms of where the near/far side of the disc is located in those respective cases.
Based on your LkCa15 example, am I right to assume that the part of the disc located counter-clockwise from the PA of semi-major axis is the far (resp. near) side when the sign is positive (resp. negative)?
Sorry if this information is provided somewhere and I missed it. Otherwise, I'd suggest to add it in the description of the inclination parameter. Thanks again!

@tomasstolker
Copy link
Owner

Hi @VChristiaens,

Good to hear that diskmap has been useful!

Based on your LkCa15 example, am I right to assume that the part of the disc located counter-clockwise from the PA of semi-major axis is the far (resp. near) side when the sign is positive (resp. negative)?

Yes that is correct. So for an inclination of 0-90 deg and a position angle of 0 deg, the near side will be on the right side of the image. By increasing the position angle, the mapping will rotate in counter-clockwise direction. To be sure, the easiest is to check the _radius.fits file with using a somewhat large inclination. In that case the distances on the near side will show up as more strongly compressed compared to the far side.

Thanks for pointing that out. I will make a note in the documentation!

@tomasstolker tomasstolker added the question Further information is requested label Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants