-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dark mode #544
Comments
There is definitely demand for this feature. I am not at all a web designer, I'm afraid, but I want to express support for it. Purely from the perspective of an end user, your proposal seems reasonable. I really like the way mdbook handles things, though I have no idea if that meets the requirements you've listed. |
If you make a reasonable implementation of dark mode, I will be happy to merge it. |
want it too, strange to see it's absence... |
th
This looks nice ! Somewhat brighter and warmer than Github dark mode, but really readable. Do you have some code (shell, toml & rust) screenshots as well ? |
@Jhraumg Thanks for the feedback. I also tried some quick solutions to make dark theme work nicely with bulma but they didn't work, so I had to do it manually. I don't have any more screenshots right now. I will finish this work in some days and then you will be able to preview it. |
The website should have a dark mode that based on
prefers-color-scheme
media query.There's no built-in support for dark mode in Bulma (jgthms/bulma#2342) so I imagine it has be implemented by manually tweaking the color values.
The text was updated successfully, but these errors were encountered: