-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.1.x: clean up warnings #3069
Conversation
@@ -144,12 +144,6 @@ use crate::stdlib::{ | |||
error, | |||
}; | |||
|
|||
#[cfg(feature = "alloc")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no alloc
features defined in this crate right now.
@@ -1,12 +1,8 @@ | |||
#[cfg(feature = "futures-01")] | |||
mod futures_01; | |||
|
|||
#[cfg(feature = "futures_preview")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There doesn't appear to be defined feature for futures_preview
.
@@ -70,33 +70,8 @@ where | |||
} | |||
} | |||
|
|||
#[cfg(feature = "tower-util")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no feature defined for tower-util
.
776980e
to
eb045f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, fixes all the clippy/fmt errors I got (except the comment obviously).
@hawkw so do you want to approve this? (I technically seem to have merge privileges, not sure if you want me to use them.) |
6e64256
to
4956112
Compare
4956112
to
7fc7b16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; would be good to have these on master as well.
What's the state of master these days? Feels like keeping master for 0.2.x is a little counterproductive if the pace towards actually releasing 0.2.x is low. |
I agree. IMO either we try to release 0.2.x soonish, or we reverse the roles and have 0.1.x -> master and master -> 0.2.x. |
Motivation
Trying to clean up the proliferation of warnings seen with rustc 1.80 (and
--all-features
).(Best reviewed per commit.)