tracing-appender: support rolling file using local time #3105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messense
commented
Oct 15, 2024
| #[cfg(test)] | ||
| return (self.now)(); | ||
| #[cfg(feature = "local-time")] | ||
| return OffsetDateTime::now_local().unwrap_or_else(|_| OffsetDateTime::now_utc()); |
There was a problem hiding this comment.
Not sure about this error handling though, suggestions welcome!
There was a problem hiding this comment.
IMO we should panic here. Otherwise we would failover "silently" which isn't so nice here.
messense
force-pushed
the
tracing-appender-local-time
branch
from
3f520c1
to
e4dddf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #3102
Solution
Add a
local-timefeature totracing-appender(just like the one intracing-subscriber) to modify the behavior.