v0.1.x: clean up warnings #5317

error: empty doc comment --> tracing-subscriber/src/lib.rs:243:5 | 243 | /// | ^^^ | = help: consider removing or filling it = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs = note: `-D clippy::empty-docs` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::empty_docs)]`

usage of a legacy numeric constant: tracing-subscriber/src/fmt/time/datetime.rs#L255

error: usage of a legacy numeric constant --> tracing-subscriber/src/fmt/time/datetime.rs:255:53 | 255 | debug_assert!(duration.as_secs() <= std::i64::MAX as u64); | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants help: use the associated constant instead | 255 | debug_assert!(duration.as_secs() <= i64::MAX as u64); | ~~~~~~~~

usage of a legacy numeric constant: tracing-subscriber/src/fmt/time/datetime.rs#L250

error: usage of a legacy numeric constant --> tracing-subscriber/src/fmt/time/datetime.rs:250:53 | 250 | debug_assert!(duration.as_secs() <= std::i64::MAX as u64); | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants help: use the associated constant instead | 250 | debug_assert!(duration.as_secs() <= i64::MAX as u64); | ~~~~~~~~

doc list item missing indentation: tracing-subscriber/src/fmt/format/mod.rs#L677

error: doc list item missing indentation --> tracing-subscriber/src/fmt/format/mod.rs:677:9 | 677 | /// object. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 677 | /// object. | ++

doc list item missing indentation: tracing-subscriber/src/fmt/format/json.rs#L67

error: doc list item missing indentation --> tracing-subscriber/src/fmt/format/json.rs:67:5 | 67 | /// object. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 67 | /// object. | ++

doc list item missing indentation: tracing-subscriber/src/fmt/format/json.rs#L65

error: doc list item missing indentation --> tracing-subscriber/src/fmt/format/json.rs:65:5 | 65 | /// span | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 65 | /// span | ++

doc list item missing indentation: tracing-subscriber/src/fmt/format/json.rs#L63

error: doc list item missing indentation --> tracing-subscriber/src/fmt/format/json.rs:63:5 | 63 | /// the root | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 63 | /// the root | ++

initializer for `thread_local` value can be made `const`: tracing-subscriber/src/fmt/fmt_layer.rs#L946

error: initializer for `thread_local` value can be made `const` --> tracing-subscriber/src/fmt/fmt_layer.rs:946:43 | 946 | static BUF: RefCell<String> = RefCell::new(String::new()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `const { RefCell::new(String::new()) }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#thread_local_initializer_can_be_made_const

doc list item missing indentation: tracing-subscriber/src/fmt/fmt_layer.rs#L575

error: doc list item missing indentation --> tracing-subscriber/src/fmt/fmt_layer.rs:575:9 | 575 | /// object. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 575 | /// object. | ++

doc list item missing indentation: tracing-subscriber/src/layer/mod.rs#L573

error: doc list item missing indentation --> tracing-subscriber/src/layer/mod.rs:573:4 | 573 | //! The layers and filters would be composed thusly: | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation = note: `-D clippy::doc-lazy-continuation` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::doc_lazy_continuation)]` help: indent this line | 573 | //! The layers and filters would be composed thusly: | ++

usage of a legacy numeric constant: tracing-subscriber/src/registry/sharded.rs#L355

error: usage of a legacy numeric constant --> tracing-subscriber/src/registry/sharded.rs:355:28 | 355 | assert!(refs < std::usize::MAX, "reference count overflow!"); | ^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants help: use the associated constant instead | 355 | assert!(refs < usize::MAX, "reference count overflow!"); | ~~~~~~~~~~

initializer for `thread_local` value can be made `const`: tracing-subscriber/src/registry/sharded.rs#L217

error: initializer for `thread_local` value can be made `const` --> tracing-subscriber/src/registry/sharded.rs:217:39 | 217 | static CLOSE_COUNT: Cell<usize> = Cell::new(0); | ^^^^^^^^^^^^ help: replace with: `const { Cell::new(0) }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#thread_local_initializer_can_be_made_const = note: `-D clippy::thread-local-initializer-can-be-made-const` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::thread_local_initializer_can_be_made_const)]`

usage of a legacy numeric constant: tracing-subscriber/src/filter/layer_filters/mod.rs#L1054

error: usage of a legacy numeric constant --> tracing-subscriber/src/filter/layer_filters/mod.rs:1054:22 | 1054 | self.bits != std::u64::MAX | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants help: use the associated constant instead | 1054 | self.bits != u64::MAX | ~~~~~~~~

usage of a legacy numeric constant: tracing-subscriber/src/filter/layer_filters/mod.rs#L1032

error: usage of a legacy numeric constant --> tracing-subscriber/src/filter/layer_filters/mod.rs:1032:20 | 1032 | if mask == std::u64::MAX { | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants help: use the associated constant instead | 1032 | if mask == u64::MAX { | ~~~~~~~~

usage of a legacy numeric constant: tracing-subscriber/src/filter/layer_filters/mod.rs#L889

error: usage of a legacy numeric constant --> tracing-subscriber/src/filter/layer_filters/mod.rs:889:14 | 889 | Self(std::u64::MAX) | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants help: use the associated constant instead | 889 | Self(u64::MAX) | ~~~~~~~~

usage of a legacy numeric constant: tracing-subscriber/src/filter/env/field.rs#L510

error: usage of a legacy numeric constant --> tracing-subscriber/src/filter/env/field.rs:510:41 | 510 | if (value - *e).abs() < std::f64::EPSILON => | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants help: use the associated constant instead | 510 | if (value - *e).abs() < f64::EPSILON => | ~~~~~~~~~~~~

usage of a legacy numeric constant: tracing-subscriber/src/filter/env/field.rs#L270

error: usage of a legacy numeric constant --> tracing-subscriber/src/filter/env/field.rs:270:51 | 270 | ValueMatch::NaN => fmt::Display::fmt(&std::f64::NAN, f), | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `-D clippy::legacy-numeric-constants` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::legacy_numeric_constants)]` help: use the associated constant instead | 270 | ValueMatch::NaN => fmt::Display::fmt(&f64::NAN, f), | ~~~~~~~~

warnings

Clippy had exited with the 101 exit code

cargo check

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

cargo fmt