Fix thread parking on WebAssembly #7041
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
reviewed
Dec 16, 2024
Darksonn
added
A-tokio
|
Taking rust-lang/rust#134389 (comment) into account, I don't see how this changes anything at all? |
surban
force-pushed
the
fix/wasm-park
branch
from
4cdd2df to
dd11668
Compare
The problem was that I have updated this PR accordingly. It should now work with and without the Rust std PR. |
On WebAssembly the notification state was not checked before sleeping and thus wrongfully ignored. Additionally this refines the check whether threads are available on a particular WebAssembly target.
surban
force-pushed
the
fix/wasm-park
branch
from
dd11668 to
f2b6449
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On WebAssembly the notification state was not checked before sleeping and thus wrongfully ignored.
Additionally this refines the check whether threads are available on a particular WebAssembly target.
Motivation
Bug #7036
Solution
Fixes #7036