Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Edgeless mode] [Bug] Cmd-Z in Safari when editing text opens previously closed tab #8725

Open
OkciD opened this issue Nov 11, 2024 · 1 comment
Labels
compat Related to browser compatibility mod:hotkey Module: related to hotkey binding type:bug Something isn't working

Comments

@OkciD
Copy link

OkciD commented Nov 11, 2024

Hello! Found a bug in edgeless mode

Steps to reproduce:

  1. Open Safari
  2. In tab A open https://try-blocksuite.vercel.app/starter/?init&mode=edgeless
  3. Open new tab B and navigate to some site (e.g. google.com)
  4. Close tab B
  5. In tab A put a shape and inut some text in it
  6. Press Cmd-Z

Actual behaviour:

  • Previously entered text is cleared - that's ok, that's what Cmd-Z is supposed to do
  • Previusly closed tab B is resurrected - thats weird

Expected behaviour:

  • Previously entered text is cleared
  • Tab B won't open
@OkciD
Copy link
Author

OkciD commented Nov 11, 2024

It seems like e.preventDefault() is needed here

, but i'm not sure :)

@donteatfriedrice donteatfriedrice added type:bug Something isn't working compat Related to browser compatibility mod:hotkey Module: related to hotkey binding labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat Related to browser compatibility mod:hotkey Module: related to hotkey binding type:bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

2 participants