Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createLoginRequest serializes undefined ACSUrls #455

Open
logancarmody opened this issue Oct 25, 2021 · 1 comment
Open

createLoginRequest serializes undefined ACSUrls #455

logancarmody opened this issue Oct 25, 2021 · 1 comment

Comments

@logancarmody
Copy link

For a given protocol, if the ACSUrl is undefined, createLoginRequest serializes this undefined ACSUrl. Some IdPs like Google can't handle the serialized undefined.

I discovered this because I was misconstructing the Service Provider, so this was based out of user error. However, I don't think this is the correct behavior. I think the lib should either:

  • Throw an exception
  • Don't serialize the ACSUrl at all since it's optional in Saml2.0
@tngan
Copy link
Owner

tngan commented Nov 7, 2021

@logancarmody Thanks for your advice, I agree that the construction process is not that straightforward right now, we will simplify and enhance with more restricted validation when we restructure the v3 API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants