-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libxml-xsd Dependency Introduces Breaking Change #129
Comments
@phairoh Thanks for your report, which npm and node version are you using ? |
node: 8.6.0 |
@phairoh From the library level, it doesn't break the API, so I don't think we should upgrade the major version. I would rather like to do a |
I confirm the breaking change, with many major bugs if we use PaaS environnement (like Bluemix) |
@cyberbobjr Please provide more details about the major bugs in PaaS environment. Thank you so much. |
I am sorry if this is not related to this particular issue, but I am receiving may "Warnings" while doing npm install. Here are these warnings...
|
The warning message are quite annoying, will have to investigate. |
@niswork Which node version are you using ? |
Hi @tngan I am on node v6.11.4 & npm 3.10.10. |
Hi! I confirm the breaking change too. Only v2.2.0 can be installed. Windows 10 Pro
|
Some updates, I have discovered that the package.json of libxml-xsd is not updated, since according to their latest package.json, they are using [email protected] instead of 0.16.1. Please follow the issue I have reported here. @AlexeySafronov Please take a look for this doc for window installation during the meantime. https://github.com/albanm/node-libxml-xsd/blob/f9ff21e4bba489921235b47a5949e39398a0cb87/readme.hbs |
Thanks! It's helped me. Can you add this note in Installation section for windows-developers?
|
@AlexeySafronov I am thinking if I can do something in pre-install hook, will add into documentation as well later on. (updated typo: postinstall -> preinstall, just in case if not updated) |
i am having same issue
|
Having same issue on linux and macosx
make: Entering directory '/usr/src/app/node_modules/libxmljs-mt/build' |
@nazarkulyk Would you like to give your OS version here ? |
npm install samlify
make: Entering directory '/home/us1/github.com/mcguinness/demo/node_modules/libxmljs-mt/build' npm ERR! code ELIFECYCLE npm ERR! A complete log of this run can be found in: ubuntu-18.04 |
I am currently evaluating and testing another library to do scheme validation. |
I have updated samlify, using with new schema validator. https://github.com/nikku/node-xsd-schema-validator It is using Java runtime library to do the schema validation, and it should be more stable than the one we have chosen before. I haven't released the new version to npm repository yet, but if you want to try it out, you can try the latest code base in master branch first by modifying your "samlify": "tngan/samlify" |
Hi @tngan so does this mean this module now relies on having java installed to function correctly once that changed is published? This seems like a very heavy handed approach and severely limiting and will mean I for one can no longer use this module, which is a shame as its the only one I have so far found that works well |
@microadam Yes, this is the way we consider to get rid of those build issues across most of the platforms. However, I would consider the make this part out of the box in the near future, allowing to plug different schema validator with this library. |
I will close this issue since we have changed to delegate the xml schema validation to JAVA runtime library. Please feel free to reopen it or create a new ticket once you encounter issue with the latest approach. |
@tngan Thanks for your info. Which Java version did you tested with? |
The v2.3.0 introduces a breaking change as a result of the addition of the
libxml-xsd
dependency. This library depends onlibxmljs-mt
which needs to be compiled and requires a number of additional dependencies (such as python) the lack of which will causenpm install
to fail.I suggest reverting and publishing a corrected version and republishing this version as a major release.
The text was updated successfully, but these errors were encountered: