Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of accented letters on cluster_gen is OS-dependent #46

Open
wleoncio opened this issue Jun 25, 2021 · 0 comments
Open

Removal of accented letters on cluster_gen is OS-dependent #46

wleoncio opened this issue Jun 25, 2021 · 0 comments

Comments

@wleoncio
Copy link
Collaborator

This issue concerns the following code chunk:

lsasim/R/cluster_gen.R

Lines 184 to 187 in e398e1e

# Removing accents ======================================================
if (!is.null(names(n))) names(n) <- iconv(names(n), to = "ASCII//TRANSLIT")
cluster_labels <- iconv(cluster_labels, to = "ASCII//TRANSLIT")
resp_labels <- iconv(resp_labels, to = "ASCII//TRANSLIT")

It is intended to produce the following kind of output:

image

However, this seems to not be OS-agnostic. During the lsasim 2.1.0 release cycle, I was made aware that this works on Windows and mainstream Linux distributions, but Intel Macs and Solaris yield a different output. It was also noted that some Linux distributions such as Alpine (not tested by CRAN) do not even support "//TRANSLIT" at all.

It would be ideal if this feature was thus made more universal. Alternatively, it could be dropped, and accented letters would either be parsed directly or trigger a warning/error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant