Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttributeError: 'Namespace' object has no attribute 'residual_dropout_lima' #14

Closed
cassidylaidlaw opened this issue Sep 23, 2024 · 1 comment

Comments

@cassidylaidlaw
Copy link

cassidylaidlaw commented Sep 23, 2024

Hi, thanks for making your code available! I tried to run the reward model training script:

accelerate launch --config_file configs/accelerate_config.yaml src/reward_modeling/training/trainer_rm.py --configs defaults_rm rm-pythia-44m --rng_seed 0

It failed with this error:

  File ".../llm_optimization/src/reward_modeling/training/trainer_rm.py", line 350, in <module>
    main()
  File ".../llm_optimization/src/reward_modeling/training/trainer_rm.py", line 209, in main
    model = get_model(training_conf, tokenizer)
  File ".../lib/python3.10/site-packages/model_training/utils/utils.py", line 354, in get_model
    residual_dropout_lima=conf.residual_dropout_lima,
AttributeError: 'Namespace' object has no attribute 'residual_dropout_lima'. Did you mean: 'residual_dropout'?

I change the config entry for residual_dropout to residual_dropout_lima but I wanted to make sure that this is the correct way to fix the error. It might be good to update the default config in the repo as well.

@tlc4418
Copy link
Owner

tlc4418 commented Jan 16, 2025

Thank your for raising this.

See #5 and #13, where the same issue was reported. I have now fixed this in the codebase.

@tlc4418 tlc4418 closed this as completed Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants