Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability To add/edit deployment ids through the django admin panel. #1304

Open
rpfernandezjr opened this issue Aug 13, 2021 · 5 comments · May be fixed by #1318
Open

Ability To add/edit deployment ids through the django admin panel. #1304

rpfernandezjr opened this issue Aug 13, 2021 · 5 comments · May be fixed by #1318
Assignees

Comments

@rpfernandezjr
Copy link

Describe your problem or feature you'd like added

We (Unizin) currently receive multiple requests to add/remove deployment_ids in the LTI_CONFIG config option. We would like a solution that allows MyLA administrators the ability to add/remove/edit these entries without us (Unizin) having to redeploy configurations and restarting services.

Describe the solution you'd like

Here's a list of all the current optinos/settings that admin users can do add/remove/edit

myla-admin

We would like an option added to this admin panel, that allows admin users the ability to add/remove/edit deployment_ids

@jonespm
Copy link
Member

jonespm commented Aug 13, 2021

Thanks @rpfernandezjr . This actually is a feature that was added to the PyLTI13 project . We plan on updating to this version in the next major release and could probably make the it combine both the LTI_CONFIG and database settings.

@jonespm jonespm self-assigned this Aug 13, 2021
@rpfernandezjr
Copy link
Author

Ahh thanks, I remember this was a conversation in the past, with you guys and Etienne. I didn't see an issue for it so wasn't sure if it fell through the cracks.

jonespm added a commit to jonespm/student-dashboard-django that referenced this issue Sep 16, 2021
@jonespm
Copy link
Member

jonespm commented Sep 23, 2021

I was looking at a way to configure this in the database #1318 but got into a little blocker figuring out how to make it compatible both ways easily.

Have you tried to disable the deployment id checks? There's a configuration for that now.

"LTI_CONFIG_DISABLE_DEPLOYMENT_ID_VALIDATION": true,

@jennlove-um
Copy link
Contributor

@jennlove-um Follow up with Unizin to see if they have set the configuration per Matt's question above. If this is not a current issue for them, then remove from this release. Explore other options to address this issue.

@jonespm
Copy link
Member

jonespm commented May 25, 2023

We had a PR here to use the Django Admin UI from the library, but the problem with that is you need a way to launch the tool in the first place. So it either needs a way to populate the database directly or to read and use the config values to be used.

One idea we've had as a middle ground between disabled checks and full checks that we've seen some tools do is to have you define a single deployment id, and once the tool is launched from that it's marked as being allowed from any deployment id on that configuration. This might be a good idea to implement in our local code, or even better use when/if we switch to the https://github.com/academic-innovation/django-lti library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants