Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monster abilities implement levelRequirement #29

Open
tjheslin1 opened this issue Apr 6, 2019 · 0 comments
Open

Monster abilities implement levelRequirement #29

tjheslin1 opened this issue Apr 6, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tjheslin1
Copy link
Owner

tjheslin1 commented Apr 6, 2019

Abilities must implement a levelRequirement, however monster specific abilities such as mutliAttack have no use for the levelRequirement field as Monster has no concept of Level, instead implementing a challenge rating.

There is unlikely to be any ability used by both Players and Monsters. Likely a separate implementation is more appropriate (e.g Extra Attack / Multi Attack).

One possibility is to drop levelRequirement from Ability. This is undeseriable as it's main usage is to remind the developer to implement this and consider it.

Another option is to have a Level to represent Monsters (e.g LevelZero), however this will cause issues when pattern matching over levels (see Cleric#clericSpellSlots) where this would not make sense.

@tjheslin1 tjheslin1 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Apr 6, 2019
@tjheslin1 tjheslin1 removed the help wanted Extra attention is needed label May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant