Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateTime self-filtered area doesn't align with initial data #231

Open
timwis opened this issue Apr 26, 2018 · 0 comments
Open

DateTime self-filtered area doesn't align with initial data #231

timwis opened this issue Apr 26, 2018 · 0 comments
Labels

Comments

@timwis
Copy link
Owner

timwis commented Apr 26, 2018

When you select a range in a datetime, the filtered area should align exactly to your selection. Currently it's a bit off.

screen shot 2018-04-26 at 7 35 03 am

We could use a <clipPath>, but that doesn't solve the fact that part of the filtered data is "missing" (top right of image)

EDIT: Ah -- the initial query does date_trunc('month', dispatch_date), which groups all 31 days in january under one january bucket. The filtered query does where dispatch_date <= jan 1st, which is only one day in january. Vizwit v1 appears to trigger by the last day of the month. So when you select january in the datetime chart, it should trigger a filter to january 31st. But what if the chart isn't grouped by month, and grouped by day or year instead? Perhaps if we change it to < the next item on the scale. (ie. < feb 1st)

@timwis timwis added the v2 label Apr 26, 2018
@timwis timwis changed the title DateTime DateTime self-filtered area doesn't align with initial data Apr 26, 2018
@timwis timwis added the bug label May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant