Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API to upload files from memory (such as a &[u8]?) #67

Open
nightkr opened this issue Nov 9, 2019 · 3 comments
Open

API to upload files from memory (such as a &[u8]?) #67

nightkr opened this issue Nov 9, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@nightkr
Copy link

nightkr commented Nov 9, 2019

It would be great to be able to upload files without storing them on disk. Realistically, that probably means:

  1. Supplying an artificial FileData
  2. Supplying a custom Read
@nightkr nightkr changed the title API to upload files from a u8 slice API to upload files from memory (such as a &[u8]?) Nov 9, 2019
@timvisee
Copy link
Owner

Sounds like a nice idea, and implementing this is definitely possible.

Requirements for uploading files are:

  • Known file size
  • File name & MIME

I'm not sure when I'm able to implement this, due to other priorities. Nor do I know how much work it would be, as it has been a while when I last worked on the file handling part.

The current ffsend-api is a little messy, as it was iteratively developed along with ffsend without too much prior design work. It currently only accepts a File (I believe) in the Upload action. But I'd like to better design this to support different sources as well some time.

It's definitely something I'd like to add though. If you want to give implementing this a try, give it a go!

@timvisee timvisee added the enhancement New feature or request label Nov 11, 2019
@nightkr
Copy link
Author

nightkr commented Nov 11, 2019

Oh sorry, didn't see that the canonical repo seems to be on GitLab.

@timvisee
Copy link
Owner

@teozkr No problem. I'm monitoring both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants