Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.vdc export broken for some ParametricEQ profiles #5

Open
NipOc opened this issue Jun 4, 2020 · 7 comments
Open

.vdc export broken for some ParametricEQ profiles #5

NipOc opened this issue Jun 4, 2020 · 7 comments

Comments

@NipOc
Copy link

NipOc commented Jun 4, 2020

Some ParametricEQs profiles, like the one for the Hifiman Deva (wireless), get exported with missing settings and crash the Viper4Android app.
DDC-Toolbox

@timschneeb
Copy link
Owner

timschneeb commented Jun 4, 2020

These NaN values are completely normal and should be supported by Viper4Android.
However, their VDC parser seems to be broken in 2.7.1.6 as the devs forgot to handle number conversion exceptions. The upcoming V4A version has this issue fixed and until then you can replace these coefficients with zeroes. (Related issue #3)

@james34602 james34602 reopened this Jun 5, 2020
@james34602
Copy link
Collaborator

@ThePBone NaN need to be fixed.
Wild bandwidth, negative frequency are the only way to get NaN result.
We have to replace the SOS with NaN by unity gain [1.0,0,0,0,0]
Or replace by a constant gain filter that pole and zero annihilate each other to form constant gain, like this [1.99526231496888,0,-1.99526231496888,0,1].

@timschneeb
Copy link
Owner

Oh, alright I didn't know that. So would you rather recommend to replace the affected filter by a unity gain or by a constant gain filter?

@james34602
Copy link
Collaborator

right, however before @ThePBone make any fix.
Please @NipOc provide the vdcproj file so we can debug, let me evaluate what filter cause NaN first.

@NipOc
Copy link
Author

NipOc commented Jun 5, 2020

It looks like the project wasn't saved correctly, so I included the PrarametricEQ file, too.

HIFIMAN Deva (wireless) ParametricEQ.txt
HIFIMAN Deva (wireless) ParametricEQ.vdc.txt
HIFIMAN Deva (wireless) ParametricEQ.vdcprj.txt

@timschneeb
Copy link
Owner

About the .vdcprj saving issue:

You're using a nightly build, right? In one of the last commits was a typo breaking the save feature under certain circumstances. The latest nightly build (1.3.91) has this issue fixed -> Direct download link

@NipOc
Copy link
Author

NipOc commented Jun 5, 2020

Thanks, it's working now.

HIFIMAN Deva (wireless) ParametricEQ.vdcprj.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants