Add a LEAD_TIME variable to config

[trillium]

Hey Tim,

I have a usecase where I need to make sure that appointments can't be booked unless they're at least LEAD_TIME minutes in the future. I'd like to add this to your project. As it stands now, I believe at 3:58pm a call can be scheduled for 4:00pm.

I definitely want this timer to be able to be a different size from the SLOT_PADDING variable.

Is that something you'd welcome being added to this project?

Proposal

Add a LEAD_TIME variable to config.ts so that appointments must be at least LEAD_TIME minutes in the future.

[timfee]

Yeah, that’s a great call. I’m working on a refactored version for the latest Nextjs version but you’re welcome to add it here with my most sincere gratitude!

…

On Sat, May 27, 2023 at 10:32 AM Trillium S ***@***.***> wrote: Hey Tim, I have a usecase where I need to make sure that appointments can't be booked unless they're at least LEAD_TIME minutes in the future. I'd like to add this to your project. As it stands now, I *believe* at 3:58pm a call can be scheduled for 4:00pm. I definitely want this timer to be able to be a different size from the SLOT_PADDING variable. Is that something you'd welcome being added to this project? Proposal Add a LEAD_TIME variable to config.ts so that appointments must be at least LEAD_TIME minutes in the future. — Reply to this email directly, view it on GitHub <#12>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAYYSBTHNKBSD4VSGMX3LOTXII3B7ANCNFSM6AAAAAAYRJTXXU> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[trillium]

Nice, curious to what you're cooking up :)

[trillium]

I think I'm having a misunderstanding of how getAvailability works. Either that or I could use some help writing the right tests (I historically haven't written many tests).

---

My initial thought was to add a busy window to the front of the array:

export default function getAvailability({
  potential: potentialParam,
  busy,
  padding = SLOT_PADDING,
  leadTime = LEAD_TIME,
}: 

...

const now = new Date()

  const leadTimeBuffer = {
    start: now, end: add(now, {minutes: leadTime})
  }

//add leadTimeBuffer to front of busy array
busy?.unshift(leadTimeBuffer)

I think that should work. If I'm understanding how the code is written right now (this is mostly for me, but if you see something in here that doesn't make sense let me know):

1. getAvailability receives one single argument with multiple properties.
2. One of those properties is Obj.potential, which is a list of applicable time windows where an appointment could be generated.
3. The Obj.potential time windows are already split into the correct size, which is duration, a variable the user selects from options provided within ALLOWED_DURATIONS.
4. The Obj.potential array is stripped of all the time windows listed that are in the past, and then deep copied into remainingSlots.
5. This original array in Obj.potential is then looped over, each available freeSlot is tested against the values in Obj.busy via nested loop
6. If they overlap (tested by function areIntervalsOverlapping) that potential freeSlot marked as not free via bolean isFree, and the loop is ended via break, ending that specific iteration of the nested for loop.
7. back in the main for loop, isFree is used as the conditional to add the slot to the openSlots array. If it was marked as not free, the condition of the if() {} isn't met, meaning that specific freeSlot is skipped due to overlap with an element inObj.busy
8. The freeSlot is checked to see if it still in the remainingSlots array via remainingSlots.indexOf, and if it is, removed via .splice
9. Once the for loop has run it's course. All the open time slots have been pushed to the openSlots array. This array is then returned by by the getAvailability function, to be consumed elsewhere in the application.

If that's correct, then adding another busy time to Obj.busy should do it. It should probably also be conditionally rendered incase the user leaves LEAD_TIME at 0. No point in adding a time block that is just {start: now, end: now}