-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky append regression test #7512
Conversation
@erimatnor, @akuzm: please review this pull request.
|
b9fdad7
to
2b0847b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although this works fine in most cases, it makes it impossible to, for example, test for the number of heap fetches in particular tests.
Approving since I can't see that it is something we are doing right now, so we can deal with it when the need arises.
Shouldn't this be fixed by vacuum as well? IIRC we had a similar problem for transparent decompression test |
bd9401a
to
ca7c4d0
Compare
I've sent another commit executing a manual VACUUM and it changed a lot the output: ca7c4d0 At least all the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7512 +/- ##
==========================================
+ Coverage 80.06% 82.18% +2.11%
==========================================
Files 190 230 +40
Lines 37181 43191 +6010
Branches 9450 10869 +1419
==========================================
+ Hits 29770 35495 +5725
- Misses 2997 3371 +374
+ Partials 4414 4325 -89 ☔ View full report in Codecov by Sentry. |
Fixed it by manually running `VACUUM ANALYZE` in all involved hypertables to avoid flaky output tests.
ca7c4d0
to
dc4cde3
Compare
Fixed it by manually running
VACUUM ANALYZE
in all involved hypertables to avoid flaky output tests.https://github.com/timescale/timescaledb/actions/runs/12128976291/job/33819502944?pr=7505#step:17:23
Disable-check: force-changelog-file