Skip to content

Commit e525b27

Browse files
authored
feat(deps): push past the cli split out [INFRA-33946] (#330)
1 parent 06db9a2 commit e525b27

File tree

3 files changed

+20
-6
lines changed

3 files changed

+20
-6
lines changed

src/clickup-cdk.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ import { updateProjen } from './update-projen';
1717
import { parameters } from './utils/parameters';
1818

1919
export module clickupCdk {
20-
const minCdkVersion = '2.138.0'; // https://github.com/aws/aws-cdk/issues/29746
21-
const defaultCdkVersion = '2.138.0';
20+
const minCdkVersion = '2.189.0'; // let's push past the (painful) split of the cli
21+
const defaultCdkVersion = '2.189.0';
2222

2323
export const deps = [
2424
...clickupTs.deps,
@@ -233,6 +233,12 @@ export module clickupCdk {
233233
renovatebotOptions: renovateWorkflow.getRenovateOptions(options.renovateOptionsConfig),
234234
});
235235
super(mergedOptions);
236+
237+
// We need to deal with the cli split
238+
// https://github.com/projen/projen/issues/4157
239+
// https://aws.amazon.com/blogs/opensource/aws-cdk-is-splitting-construct-library-and-cli/
240+
this.addDeps('aws-cdk@^2.1007.0'); // skip past the first few versions of the CLI, they were rough.
241+
236242
this.workflowNodeVersion = mergedOptions.workflowNodeVersion;
237243
clickupTs.fixTsNodeDeps(this.package);
238244
new AppSampleCode(this);

test/__snapshots__/clickup-cdk.test.ts.snap

Lines changed: 8 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/clickup-cdk.test.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@ describe('ClickUpCdkTypeScriptApp', () => {
2020
expect(synth[file]).toMatchSnapshot();
2121
});
2222
});
23+
24+
test('aws-cdk cli lib is at least 2.1007.0', () => {
25+
expect(synth['package.json'].dependencies['aws-cdk']).toBe('^2.1007.0');
26+
});
2327
test('prettier is enabled', () => {
2428
expect(p.prettier).toBeTruthy();
2529
});

0 commit comments

Comments
 (0)