Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can this be used to remove these tags #3

Open
bonelifer opened this issue May 16, 2024 · 5 comments
Open

Can this be used to remove these tags #3

bonelifer opened this issue May 16, 2024 · 5 comments
Assignees
Labels
blocked Something can not be done unless something else was done enhancement New feature or request

Comments

@bonelifer
Copy link

Need to remove these, so I can reapply replaygain.

replaygain_album_gain
replaygain_album_peak
replaygain_reference_loudness
replaygain_track_gain
replaygain_track_peak
rgain:album
rgain:track
MP3GAIN_ALBUM_MINMAX
MP3GAIN_MINMAX
MP3GAIN_UNDO

@tillt
Copy link
Owner

tillt commented May 16, 2024

Shouldn't be too hard - lemme look into that tonight....

@tillt
Copy link
Owner

tillt commented May 16, 2024

...added such functionality. There is a new command flag you can use for enabling that feature; ungain.

@bonelifer give it a shot!

./cleanid3 -clean=false -ungain=true test.mp3

Removing frame TXXX:replaygain_reference_loudness
Removing frame TXXX:replaygain_track_gain
Removing frame TXXX:replaygain_track_peak
Removing frame TXXX:MP3GAIN_MINMAX

@tillt tillt self-assigned this May 16, 2024
@tillt tillt added the enhancement New feature or request label May 16, 2024
@bonelifer
Copy link
Author

Missing, these but otherwise works:
rgain:album
rgain:track

It would be helpful to have forbidden-id3.txt to make some tags easier to remove. For instance, one of the tags has 512 right now. However, another tag might contain those numbers. By specifying the ID3 tag to remove, accidental deletions can be avoided.

@tillt
Copy link
Owner

tillt commented May 17, 2024

Good idea to have them in a configuration file indeed. About the tags rgain:album & rgain:track that's cause I did not check the specs before implementing; those are part of ID3v2.4, controlled by RVA2 tags and not as currently implemented as TXXX tags.

So in other words, your desired configuration file for unwanted tags would be something like this:

RVA2:rgain:album
RVA2:rgain:track
TXXX:replaygain_album_gain
TXXX:replaygain_album_peak
TXXX:replaygain_reference_loudness
TXXX:replaygain_track_gain
TXXX:replaygain_track_peak
TXXX:MP3GAIN_MINMAX
TXXX:MP3GAIN_UNDO

I'll look into this...

@tillt
Copy link
Owner

tillt commented May 17, 2024

Dangit - seems the underlying ID3 lib (https://github.com/n10v/id3v2) does not support the ID3 version 2.4 RVA2 tag. Adding it to the library is certainly possible but not entirely trivial. I have opened an issue there but am not too hopeful anyone will tackle that soon; n10v/id3v2#90.

@tillt tillt added the blocked Something can not be done unless something else was done label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Something can not be done unless something else was done enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants