Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_cruise_planner)!: relax unknown stop #1612

Merged
merged 9 commits into from
Oct 31, 2024

Conversation

yuki-takagi-66
Copy link

@yuki-takagi-66 yuki-takagi-66 commented Oct 29, 2024

Description

https://star4.slack.com/archives/C015H42UVBK/p1729760774267989 の件
「unknownに対しては、preferred_acc_for_unknown(defaultでは-3.0m/ss)で本来のマージン距離(基本的にはsafe_distance_marginで指定される値)を開けた停止位置に止まれなさそうなら、preferred_acc_for_unknownで止まれるように停止位置を先に伸ばす。ただし、limit_margin_for_unknownで指定されるマージン(defaultでは3m)は確保し続ける。」
の変更PRです。

universe PR: https://github.com/tier4/autoware_launch.x2/pull/822

Related links

Parent Issue:

  • Link

How was this PR tested?

psim and lsim

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

saka1-s and others added 5 commits October 1, 2024 09:33
fix dependency of mult object tracker
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
@yuki-takagi-66 yuki-takagi-66 changed the title qBv0191+relax unknown stop feat(obstacle_cruise_planner)!: relax unknown stop Oct 29, 2024
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review October 30, 2024 02:21
Signed-off-by: Yuki Takagi <[email protected]>
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saka1-s saka1-s changed the base branch from beta/v0.19.1 to beta/v0.19.1-pc-develop October 31, 2024 11:40
@saka1-s saka1-s enabled auto-merge (squash) October 31, 2024 11:41
@saka1-s saka1-s merged commit c2abb5c into beta/v0.19.1-pc-develop Oct 31, 2024
12 of 15 checks passed
@saka1-s saka1-s deleted the bv0191+relax_unknown_stop branch October 31, 2024 11:42
Copy link

sonarcloud bot commented Oct 31, 2024

saka1-s added a commit that referenced this pull request Nov 11, 2024
* chore: fix dependency of mult object tracker (#1567)

fix dependency of mult object tracker

* add relax logic

Signed-off-by: Yuki Takagi <[email protected]>

* define params

Signed-off-by: Yuki Takagi <[email protected]>

* add universe params

Signed-off-by: Yuki Takagi <[email protected]>

* delete null line

Signed-off-by: Yuki Takagi <[email protected]>

* fix spell

Signed-off-by: Yuki Takagi <[email protected]>

* fix

Signed-off-by: Yuki Takagi <[email protected]>

* change universe params

Signed-off-by: Yuki Takagi <[email protected]>

---------

Signed-off-by: Yuki Takagi <[email protected]>
Co-authored-by: Shohei Sakai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants