feat(marker_radar_lidar_calibrator): t4 garage xx1 experiment [DO NOT MERGE]#195
Draft
knzo25 wants to merge 3 commits intofeature/marker_radar_lidar_calibrator_support_radars_and_transformation_algorithmsfrom
Conversation
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Contributor
Author
|
@vividf Please provide a commit in which this does not happen. This should be possible by setting an appropriate max cluster z. |
7 tasks
Contributor
|
I changed the cluster max size from 2000 to 500 and it became more stable. |
Contributor
|
@knzo25 branch is updated for some changes. |
* chore: tune parameter setting for smooth calibration Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix default rviz for text markers Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix default rviz for text markers Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: remove unused header Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: change function name to evaluateCombinations Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: change function name to get2DRotationDelta Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: change variable name Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix waiting to extract the background model Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix grammar error Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix function name and clean code Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: remove unnessary logging Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix int to size_t Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix estimateZeroRollTransformation logging Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: add std::size_t Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: NULL to nullptr Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: declare point type only once Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: remove class member and declare new structure Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix description of radar_optimization_frame Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: remove if condition Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix function name setDelta Signed-off-by: vividf <yihsiang.fang@tier4.jp> --------- Signed-off-by: vividf <yihsiang.fang@tier4.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Making a dummy PR do evaluate and comment about the changes required to perform radar calibration in the garage
Related links
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.