Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-over fishing bug #48

Open
Hunteil opened this issue May 11, 2020 · 2 comments
Open

Cross-over fishing bug #48

Hunteil opened this issue May 11, 2020 · 2 comments

Comments

@Hunteil
Copy link

Hunteil commented May 11, 2020

See bug from here... Sorry it's a cross-over bot issue (maybe still you can assist in?)
ilpersi/BHBot#161 (comment)

Just in case the bug report is deleted... the bug happens in
https://github.com/ilpersi/BHBot

(Just copying and pasting to here)
Describe the bug
So the fishing bot keeps messing up... it'll randomly forget to move the mouse away from the Start, Cast, Catch, Trade button (which changes color based on mouse placement). This in turn will cause the bot to hang waiting for the button to appear. If you miss the catch during this. It'll hang forever in the It got away! dialog box... if this sits forever like this... the main bot will re-awaken and restart the BHBot... unless the user manually closes the It got away! box and does something else... Then the fishing bot will still be waiting in the back ground until you click fishing and try to catch something again and it'll start again... (I know this b/c I accidentally discovered this.) If this is allowed to happen (worst case scenario)... we maybe using a few instances of the fishing bot while the normal bot is working and tieing up resources.

As far as the bot itself hanging for that button...if you manually close the it got away box... make sure you return the game to the capture button and it'll re-continue.

Things to consider
I thought first it was b/c of my wireless mouse was shutting off and sending a signal messing it up. But I manually turned it off and watched and it just kept happening. And I would have to turn it back on and correct it's mouse placement.

After fixing the placement of my mouse for the bot a few dozen times, it started operating perfectly for 5 minutes. So maybe something is going on in the background of the PC that's slowing it down or something?

Solution
Add a few more safe guard steps to ensure the mouse pointer is away or include the button images being depressed as targets too.

@tiemonl
Copy link
Owner

tiemonl commented May 14, 2020

Hey, if I had to guess, I’d say this issue is similar to #47 but I never got a response back. I can add a second delay to each action to help avoid it. I’ll have to make a new release, then BHBot will have to use the latest release of this program for you to be able to see the changes on your end.

@Hunteil
Copy link
Author

Hunteil commented May 21, 2020

When this happened... The fps was acting as normal. (I don't have a fps counter and I was only running the BHBot and the game at the time to reduce any fps interference. But it's possible it was a lag somewhere... it's a quad core CPU and a 12yr gaming pc. So maybe it's missing a tick or something?

If I could see the script/program running in my command line I could tell better but it only says: pausing to run fish bot or whatever for a set amount of time. Then turns it off when done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants