Race condition using redcon v1.6.0 #61
Comments
|
I'm unable to reproduce. I wrapped your example in this program: package main
import (
"github.com/buraksezer/olric"
"github.com/buraksezer/olric/config"
)
func main() {
olricInstance := config.New("local")
db, err := olric.New(olricInstance)
if err != nil {
panic(err)
}
go func() {
_ = db.Start()
}()
}And I did The program printing and ended successfully. |
|
Hey, @tidwall I have prepared a sample for you. If you run the following code snippet by enabling the race detector, you will see the problem. I would greatly appreciate any help. package main
import (
"context"
"fmt"
"log"
"time"
"github.com/buraksezer/olric"
"github.com/buraksezer/olric/config"
)
func main() {
// Sample for Olric v0.5.x
// Deployment scenario: embedded-member
// This creates a single-node Olric cluster. It's good enough for experimenting.
// config.New returns a new config.Config with sane defaults. Available values for env:
// local, lan, wan
c := config.New("local")
// Callback function. It's called when this node is ready to accept connections.
ctx, cancel := context.WithCancel(context.Background())
c.Started = func() {
defer cancel()
log.Println("[INFO] Olric is ready to accept connections")
}
// Create a new Olric instance.
db, err := olric.New(c)
if err != nil {
log.Fatalf("Failed to create Olric instance: %v", err)
}
// Start the instance. It will form a single-node cluster.
go func() {
// Call Start at background. It's a blocker call.
err = db.Start()
if err != nil {
log.Fatalf("olric.Start returned an error: %v", err)
}
}()
<-ctx.Done()
// In embedded-member scenario, you can use the EmbeddedClient. It implements
// the Client interface.
e := db.NewEmbeddedClient()
dm, err := e.NewDMap("bucket-of-arbitrary-items")
if err != nil {
log.Fatalf("olric.NewDMap returned an error: %v", err)
}
ctx, cancel = context.WithCancel(context.Background())
// Magic starts here!
fmt.Println("##")
fmt.Println("Simple Put/Get on a DMap instance:")
err = dm.Put(ctx, "my-key", "Olric Rocks!")
if err != nil {
log.Fatalf("Failed to call Put: %v", err)
}
gr, err := dm.Get(ctx, "my-key")
if err != nil {
log.Fatalf("Failed to call Get: %v", err)
}
// Olric uses the Redis serialization format.
value, err := gr.String()
if err != nil {
log.Fatalf("Failed to read Get response: %v", err)
}
fmt.Println("Response for my-key:", value)
fmt.Println("##")
// Don't forget the call Shutdown when you want to leave the cluster.
ctx, cancel = context.WithTimeout(context.Background(), 10*time.Second)
defer cancel()
err = db.Shutdown(ctx)
if err != nil {
log.Printf("Failed to shutdown Olric: %v", err)
}
} |
|
Thanks for detailed example. Also, in your example code, you have a minor race condition at: // Start the instance. It will form a single-node cluster.
go func() {
// Call Start at background. It's a blocker call.
err = db.Start()
if err != nil {
log.Fatalf("olric.Start returned an error: %v", err)
}
}()The line |
|
Thank you @tidwall, I'll update the documentation. |
|
My pleasure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello, there is a race condition in the redcon library used by olric v0.5.0. I was testing my code using
go test -raceand this warning appeared.Sample
Output
The text was updated successfully, but these errors were encountered: