Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for context.Context #51

Open
nathanhack opened this issue Nov 16, 2021 · 3 comments
Open

Support for context.Context #51

nathanhack opened this issue Nov 16, 2021 · 3 comments

Comments

@nathanhack
Copy link

It would be great if there was support for context.Context. So that I could capture os.Signals and kill the server in a nice way.

@nathanhack
Copy link
Author

I have added in my fork https://github.com/nathanhack/redcon
I directly added context, making it not backwards compatible with v1.
Would a PR be something you're interested in (I would expect you would have some feedback on matching your style and backwards compatibility)?

@nathanhack
Copy link
Author

I added a PR #52 for this issue

@hiqsociety
Copy link

@nathanhack can u help add context and pub/sub to redhub?
https://github.com/IceFireDB/redhub
thx in advance!
can i buy u a coffee for doing so pls? hope to see it in production

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants