Merge pull request #444 from tidev/android18

feat(android): update to 18.0.3

Author: hansemannn

README.md

@@ -294,11 +294,9 @@ To share more information, example:
 
 ```javascript
     var fb = require('facebook');
+    fb.initialize();
     fb.presentShareDialog({
         link: 'https://appcelerator.com/',
-        title: 'great product',
-        description: 'Titanium is a great product',
-        picture: 'http://www.appcelerator.com/wp-content/uploads/scale_triangle1.png'
     });
 ```
 

android/build.gradle

@@ -6,5 +6,6 @@ buildscript {
 }
 
 dependencies {
-	implementation 'com.facebook.android:facebook-android-sdk:17.0.2'
+	// https://github.com/facebook/facebook-android-sdk/releases
+	implementation 'com.facebook.android:facebook-android-sdk:18.0.3'
 }

android/manifest

@@ -2,7 +2,7 @@
 # this is your module manifest and used by Titanium
 # during compilation, packaging, distribution, etc.
 #
-version: 13.0.0
+version: 14.0.0
 apiversion: 4
 architectures: arm64-v8a armeabi-v7a x86 x86_64
 description: facebook
@@ -15,4 +15,4 @@ name: Facebook
 moduleid: facebook
 guid: e4f7ac61-1ee7-44c5-bc27-fa6876e2dce9
 platform: android
-minsdk: 11.0.0
+minsdk: 12.7.0

android/src/facebook/TiFacebookModule.java

@@ -252,26 +252,6 @@ public static String handleError(FacebookRequestError error)
 		return errorMessage;
 	}
 
-	// clang-format off
-	@Kroll.getProperty
-	@Kroll.method
-	public boolean getCanPresentShareDialog()
-	// clang-format on
-	{
-		Log.w(TAG, "The getCanPresentShareDialog property is deprecated. This always returns true.");
-		return true;
-	}
-
-	// clang-format off
-	@Kroll.getProperty
-	@Kroll.method
-	public boolean getCanPresentOpenGraphActionDialog()
-	// clang-format on
-	{
-		Log.w(TAG, "The getCanPresentOpenGraphActionDialog property is deprecated. This always returns true.");
-		return true;
-	}
-
 	@Kroll.method
 	public void requestWithGraphPath(String path, KrollDict params, String httpMethod, final KrollFunction callback)
 	{
@@ -540,13 +520,8 @@ public void setPermissions(Object[] permissions)
 	}
 
 	@Kroll.method
-	public void initialize(@Kroll.argument(optional = true) int timeout)
+	public void initialize()
 	{
-		// Variable `timeout` is not used
-		// When not set, timeout is -1
-		if (timeout >= 0) {
-			Log.w(TAG, "Property `timeout` is deprecated. It is not used.");
-		}
 		callbackManager = CallbackManager.Factory.create();
 		facebookCallback = new FacebookCallback<LoginResult>() {
 			final KrollDict data = new KrollDict();
@@ -766,24 +741,9 @@ public void onSuccess(Sharer.Result results)
 		Mode mode = Mode.AUTOMATIC;
 
 		String link = (String) args.get("link");
-		String title = (String) args.get("title");
-		String description = (String) args.get("description");
-		String picture = (String) args.get("picture");
 		String placeId = (String) args.get("placeId");
 		String ref = (String) args.get("ref");
 
-		if (title != null) {
-			Log.w(TAG, "Ti.Facebook.presentShareDialog.title has been deprecated as of the Graph v2.9 changes.");
-		}
-
-		if (description != null) {
-			Log.w(TAG, "Ti.Facebook.presentShareDialog.description has been deprecated as of the Graph v2.9 changes.");
-		}
-
-		if (picture != null) {
-			Log.w(TAG, "Ti.Facebook.presentShareDialog.picture has been deprecated as of the Graph v2.9 changes.");
-		}
-
 		switch (TiConvert.toInt(args.get("mode"), TiFacebookModule.SHARE_DIALOG_MODE_AUTOMATIC)) {
 			case TiFacebookModule.SHARE_DIALOG_MODE_NATIVE:
 				mode = Mode.NATIVE;

android/timodule.xml

@@ -1,13 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <ti:module xmlns:ti="http://ti.appcelerator.org" xmlns:android="http://schemas.android.com/apk/res/android">
-	<!--
-		Similar to tiapp.xml, but contains module/platform specific
-		configuration in <iphone>, <android>, and <mobileweb> sections
-	-->
-	<iphone>
-	</iphone>
 	<android xmlns:android="http://schemas.android.com/apk/res/android">
 	</android>
-	<mobileweb>
-	</mobileweb>
 </ti:module>