Stop setting -no-module-directories in ExoPlayer javadoc generation

icbaker · tianyif · commit 8ff61a143038 · 2023-08-11T15:52:04.000Z
This flag was introduced to fix links in javadoc search when generating
it with Java 11: &lt;unknown commit&gt;

The flag is no longer supported with Java 17 (which is required for
Gradle 8.0+), and seems to no longer be needed: I generated the javadoc
with it removed and the search links work OK.

PiperOrigin-RevId: 536738686
diff --git a/javadoc_combined.gradle b/javadoc_combined.gradle
@@ -35,7 +35,6 @@ class CombinedJavadocPlugin implements Plugin<Project> {
             links "https://developer.android.com/reference", guavaReferenceUrl
             encoding = "UTF-8"
           }
-          options.addBooleanOption "-no-module-directories", true
           exclude "**/BuildConfig.java"
           exclude "**/R.java"
           doFirst {
diff --git a/javadoc_library.gradle b/javadoc_library.gradle
@@ -31,7 +31,6 @@ android.libraryVariants.all { variant ->
                   "https://guava.dev/releases/$project.ext.guavaVersion/api/docs"
             encoding = "UTF-8"
         }
-        options.addBooleanOption "-no-module-directories", true
         exclude "**/BuildConfig.java"
         exclude "**/R.java"
         doFirst {

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,6 @@ class CombinedJavadocPlugin implements Plugin<Project> {`
`35`	`35`	`links "https://developer.android.com/reference", guavaReferenceUrl`
`36`	`36`	`encoding = "UTF-8"`
`37`	`37`	`}`
`38`		`- options.addBooleanOption "-no-module-directories", true`
`39`	`38`	`exclude "**/BuildConfig.java"`
`40`	`39`	`exclude "**/R.java"`
`41`	`40`	`doFirst {`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,6 @@ android.libraryVariants.all { variant ->`
`31`	`31`	`"https://guava.dev/releases/$project.ext.guavaVersion/api/docs"`
`32`	`32`	`encoding = "UTF-8"`
`33`	`33`	`}`
`34`		`- options.addBooleanOption "-no-module-directories", true`
`35`	`34`	`exclude "**/BuildConfig.java"`
`36`	`35`	`exclude "**/R.java"`
`37`	`36`	`doFirst {`