OvmfPkg/VirtioSerialDxe: respond CONSOLE_PORT with PORT_OPEN #10575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianocore-assign-reviewers
bot
requested review from
ardbiesheuvel,
jyao1 and
kraxel
5 tasks
kraxel
approved these changes
Jan 2, 2025
|
Please put the description in the commit log of the patch so it does not get lost when merging the PR. |
t0rr3sp3dr0
force-pushed
the
patch-2
branch
2 times, most recently
from
be441af to
bfef97c
Compare
|
Done, @ardbiesheuvel! |
Thanks. Could you also fix the title please? |
t0rr3sp3dr0
force-pushed
the
patch-2
branch
2 times, most recently
from
9032c93 to
cfaf8cb
Compare
|
Sorry, missed that. Done! |
ardbiesheuvel
approved these changes
Jan 2, 2025
The VirtIO spec states that "Upon receipt of a VIRTIO_CONSOLE_CONSOLE_PORT message, the driver SHOULD treat the port in a manner suitable for text console access and MUST respond with a VIRTIO_CONSOLE_PORT_OPEN message, which MUST have value set to 1". See https://docs.oasis-open.org/virtio/virtio/v1.3/virtio-v1.3.html#x1-3330002. The current driver implementation, however, does not comply with that and only sends PORT_OPEN messages upon receipt of PORT_OPEN messages. This causes a problem in platforms like Apple's Virtualization Framework, where PORT_OPEN messages are not sent back to the driver after CONSOLE_PORT messages are received by the device, a behaviour that is compliant with the VirtIO specification. This patch addresses this issue by always responding CONSOLE_PORT messages with PORT_OPEN messages. Signed-off-by: Pedro Tôrres <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The VirtIO spec states the following (from https://docs.oasis-open.org/virtio/virtio/v1.3/virtio-v1.3.html#x1-3330002):
The current driver implementation, however, does not comply with that and only send PORT_OPEN messages when receiving PORT_OPEN messages. This causes a problem in platforms like Apple's Virtualization Framework, where PORT_OPEN messages are not sent back to the driver after CONSOLE_PORT messages, a behaviour that is compliant with the specification.
This patch addresses this issue by always responding CONSOLE_PORT messages with PORT_OPEN messages.
How This Was Tested
The driver was compiled and tested on QEMU and Virtualization Framework VMs.
Integration Instructions
N/A