Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to ROS2 #3

Open
chargerKong opened this issue Nov 2, 2021 · 7 comments
Open

Port to ROS2 #3

chargerKong opened this issue Nov 2, 2021 · 7 comments

Comments

@chargerKong
Copy link

chargerKong commented Nov 2, 2021

We've made a part port of tianracer to ROS2 which can be simply run in my tianracer(maybe compact).
The packages involved in ROS2 port up to now are

  • tianracer_core
  • tianracer_bringup
  • tianracer_description
  • tianracer_slam

There must be some parts of it that could use a cleanup, as they work around problems that may or may not still exist.

This code has been used in a few different robotics, so we know that at least the major parts of it work. And the code doesn't apply to master. If possible, we can open a new branch (maybe dashing) and I can submit a PR to improve this work

@chargerKong
Copy link
Author

I think We can start reviewing part by part

@tianb03
Copy link
Member

tianb03 commented Nov 3, 2021

Thanks Kong.
You can submit a new pull request to dashing-devel
We can start to review the code regularly.

tianb03 pushed a commit that referenced this issue Nov 6, 2021
Modify the code structure of core
@chargerKong
Copy link
Author

We suspended the portion of tianracer on ROS2 dashing

In fact, dashing is too old and its ecological is not good.

Some packages do not support dashing, such as laser_filters (but we modified their foxy code to dashing), and some packages' dashing code is unstable, especially for navigation2. They are not maintaining Dashing anymore and they said that there must be more quirky bugs see here.

I think it is very detrimental to our familiarity with the project and development. I highly recommend upgrading the system to galactic or foxy

@tianb03 What do you think?

@tianb03
Copy link
Member

tianb03 commented Dec 1, 2021

Currently, Jetson Nano does not support 20.04 officially though Ubuntu for Arm has supported it already. Ubuntu 18.04 can use foxy through source code compilation. I think upgrading Nano to 20.04 will be more preferable. We will try to make an image release for Tianracer asap, but it still will take some time.

@chargerKong
Copy link
Author

Hi @tianb03.
We've replaced Jetson Nano with Raspberry that could support 20.04 officially and installed galactic

It would be better for us to discuss it in a new branch (galactic-devel).

Note: please create this branch based on master branch, not on dashing-devel

@tianb03
Copy link
Member

tianb03 commented Jan 27, 2022

Hi @tianb03. We've replaced Jetson Nano with Raspberry that could support 20.04 officially and installed galactic

It would be better for us to discuss it in a new branch (galactic-devel).

Note: please create this branch based on master branch, not on dashing-devel

Hi @chargerKong Liangqian, we just revived from the lockdown.. I have created the galactic-devel branch. If the dashing-devel is not maintained anymore I will delete this branch

@chargerKong
Copy link
Author

OK. dashing-devel will not be maintained anymore

tianb03 pushed a commit that referenced this issue Dec 22, 2023
feat: Feature two tianracer and the simulation has been absolutely completed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants