From ff8eff78d1383cf451da22883ee48252a11f7fe3 Mon Sep 17 00:00:00 2001 From: "753.network" Date: Wed, 19 Feb 2025 10:17:57 -0500 Subject: [PATCH] Remove AllowAllCORSMixin from some API views Remove the AllowAllCORSMixin from every API except LegacyProfileRetrieveApiView, which is unlikely to cause any problems from being opened but also might not work because it redirects to a page that likely isn't open --- .../repository/api/experimental/views/package.py | 5 +---- .../repository/api/experimental/views/package_version.py | 7 +++---- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/django/thunderstore/repository/api/experimental/views/package.py b/django/thunderstore/repository/api/experimental/views/package.py index be650090c..68d314ecb 100644 --- a/django/thunderstore/repository/api/experimental/views/package.py +++ b/django/thunderstore/repository/api/experimental/views/package.py @@ -6,7 +6,6 @@ from thunderstore.cache.cache import ManualCacheCommunityMixin from thunderstore.cache.enums import CacheBustCondition -from thunderstore.core.mixins import AllowAllCORSMixin from thunderstore.repository.api.experimental.serializers import ( PackageSerializerExperimental, ) @@ -65,9 +64,7 @@ def get_queryset(self): return get_package_queryset() -class PackageDetailApiView( - AllowAllCORSMixin, ManualCacheCommunityMixin, RetrieveAPIView -): +class PackageDetailApiView(ManualCacheCommunityMixin, RetrieveAPIView): """ Get a single package """ diff --git a/django/thunderstore/repository/api/experimental/views/package_version.py b/django/thunderstore/repository/api/experimental/views/package_version.py index 6c04f2907..5fd4bc66f 100644 --- a/django/thunderstore/repository/api/experimental/views/package_version.py +++ b/django/thunderstore/repository/api/experimental/views/package_version.py @@ -5,7 +5,6 @@ from thunderstore.cache.cache import ManualCacheCommunityMixin from thunderstore.cache.enums import CacheBustCondition -from thunderstore.core.mixins import AllowAllCORSMixin from thunderstore.repository.api.experimental.serializers import ( MarkdownResponseSerializer, PackageVersionSerializerExperimental, @@ -55,7 +54,7 @@ def get_queryset(self): ) -class PackageVersionDetailApiView(AllowAllCORSMixin, PackageVersionDetailMixin): +class PackageVersionDetailApiView(PackageVersionDetailMixin): """ Get a single package version """ @@ -70,7 +69,7 @@ def get(self, *args, **kwargs): return super().get(*args, **kwargs) -class PackageVersionChangelogApiView(AllowAllCORSMixin, PackageVersionDetailMixin): +class PackageVersionChangelogApiView(PackageVersionDetailMixin): """ Get a package verion's changelog """ @@ -90,7 +89,7 @@ def retrieve(self, request, *args, **kwargs): return Response(serializer.data) -class PackageVersionReadmeApiView(AllowAllCORSMixin, PackageVersionDetailMixin): +class PackageVersionReadmeApiView(PackageVersionDetailMixin): """ Get a package verion's readme """