Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOM XSS through url parameter at GET / #7

Open
geraldino2 opened this issue Dec 8, 2023 · 0 comments · May be fixed by #8
Open

DOM XSS through url parameter at GET / #7

geraldino2 opened this issue Dec 8, 2023 · 0 comments · May be fixed by #8

Comments

@geraldino2
Copy link

When a page containing valid images is successfully loaded, unclog.js insert url into the DOM.

thumborizeme/thumborizeme/static/js/unclog.js

Line 82 in 6dd7fde

social.append('<a href="https://twitter.com/share" class="twitter-share-button" data-url="http://thumborize.me?url=' + url + '" data-text="' + tweet + '" data-hashtags="thumbor">Tweet</a>');

XSS is easily achievable. As for reference in the live demo, check it here.
geraldino2 added a commit to geraldino2/thumborizeme that referenced this issue Dec 8, 2023
@geraldino2
Encode url parameter inside HTML
e777e2a 
Fixes thumbor#7
@geraldino2 geraldino2 linked a pull request Dec 8, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Encode url parameter inside HTML geraldino2/thumborizeme
1 participant
@geraldino2